[PATCH] D153202: [LSR] Return nullptr from getExpr if the result isn't invertible.

Florian Hahn via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Mon Jun 19 04:06:04 PDT 2023


fhahn added a comment.

In D153202#4431951 <https://reviews.llvm.org/D153202#4431951>, @nikic wrote:

> Can we change normalizeForPostIncUse() to return nullptr if it does not round trip, so that all users are forced to handle this? Pretty sure this is still going to leave holes behind.

This is something I tried, but the fallout seemed quite big (in terms of test changes) so I think it would be better to incrementally make things stricter.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D153202/new/

https://reviews.llvm.org/D153202



More information about the llvm-commits mailing list