[PATCH] D151025: [llvm-exegesis] Add support for using memory annotations

[Aiden Grossman via Phabricator via llvm-commits]

aidengrossman added inline comments.


================
Comment at: llvm/tools/llvm-exegesis/lib/Assembler.cpp:236
+      MF.getRegInfo().addLiveIn(Reg);
+  } else {
+    for (const unsigned Reg : LiveIns)
----------------
courbet wrote:
> why `else` ? You could have both liveins and memory, right ? (same below)
> 
> Can you add a test ?
Ah, yep. I made it either/or here as it doesn't support passing the `RDI` (or different depending on ABI) scratch memory register, but there are definitely other uses for passing registers as live ins. Should be fixed in the next update. Thanks for the catch!


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D151025/new/

https://reviews.llvm.org/D151025