[PATCH] D151025: [llvm-exegesis] Add support for using memory annotations

[Clement Courbet via Phabricator via llvm-commits]

courbet added inline comments.


================
Comment at: llvm/tools/llvm-exegesis/lib/Assembler.cpp:236
+      MF.getRegInfo().addLiveIn(Reg);
+  } else {
+    for (const unsigned Reg : LiveIns)
----------------
why `else` ? You could have both liveins and memory, right ? (same below)

Can you add a test ?


================
Comment at: llvm/tools/llvm-exegesis/lib/BenchmarkRunner.cpp:41-42
+
+#ifdef __GLIBC__
+#if __GLIBC_MINOR__ >= 35
+#include <sys/rseq.h>
----------------
please add a `#define HAS_RSEQ` for this to make the code clearer.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D151025/new/

https://reviews.llvm.org/D151025