[PATCH] D153219: [symbolizer] Exit early if input file is absent

[James Henderson via Phabricator via llvm-commits]

jhenderson added a comment.

@MaskRay/@dblaikie, do you have any thoughts on this behaviour change?



================
Comment at: llvm/test/tools/llvm-symbolizer/errors.test:16
+CHECK-DIRECTORY: llvm-symbolizer{{.*}}: error: '{{.*}}Inputs': [[MSG]]
+
----------------
Nit: delete blank line at EOF.


================
Comment at: llvm/test/tools/llvm-symbolizer/output-style-json-code.test:7
-## Show how library errors are reported in the output.
-# RUN: llvm-symbolizer --output-style=JSON -e %p/no-file.exe 0 | \
-# RUN:   FileCheck %s -DMSG=%errc_ENOENT --check-prefix=NO-FILE --strict-whitespace --match-full-lines --implicit-check-not={{.}}
----------------
This is possibly a case where we DO want the existing behaviour. The reasoning is that JSON output is intended to be 100% machine-readable.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D153219/new/

https://reviews.llvm.org/D153219