[PATCH] D152512: [RISCV] Move getRVVMCOpcode to RISCVInstrInfo.h

Wang Pengcheng via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Sun Jun 11 23:19:46 PDT 2023


pcwang-thead added a comment.

One concern: is it possible to be false positive for these usages (though I haven't found any failed test)? When mapping pseudos to MC opcode, we may lost some information like `MASK`, `TIED`, `TU/TA`, etc.



================
Comment at: llvm/lib/Target/RISCV/RISCVInstrInfo.cpp:2145
-#define CASE_VFMA_OPCODE_COMMON(OP, TYPE, LMUL)                                \
-  RISCV::PseudoV##OP##_##TYPE##_##LMUL
-
----------------
For example, we didn't catch `_MASK` here.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D152512/new/

https://reviews.llvm.org/D152512



More information about the llvm-commits mailing list