[PATCH] D152661: [XRay] Make xray_fn_idx entries PC-relative

Fangrui Song via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Sun Jun 11 16:59:09 PDT 2023


MaskRay created this revision.
MaskRay added reviewers: dberris, ianlevesque, ilammy.
Herald added subscribers: Enna1, pengfei, atanasyan, hiraditya, kristof.beyls, arichardson, nemanjai, sdardis.
Herald added a project: All.
MaskRay requested review of this revision.
Herald added projects: Sanitizers, LLVM.
Herald added subscribers: llvm-commits, Sanitizers.

As mentioned by commit c5d38924dc6688c15b3fa133abeb3626e8f0767c <https://reviews.llvm.org/rGc5d38924dc6688c15b3fa133abeb3626e8f0767c> (Apr 2020),
PC-relative entries avoid dynamic relocations.

This is similar to D78082 <https://reviews.llvm.org/D78082> and D78590 <https://reviews.llvm.org/D78590>. We cannot commit to support
compiler/runtime built at different versions, so just don't play with versions.

I'll fix test/CodeGen/{ARM,Hexagon,Mips} tests if this change looks good.


Repository:
  rG LLVM Github Monorepo

https://reviews.llvm.org/D152661

Files:
  compiler-rt/lib/xray/xray_interface.cpp
  compiler-rt/lib/xray/xray_interface_internal.h
  llvm/lib/CodeGen/AsmPrinter/AsmPrinter.cpp
  llvm/test/CodeGen/AArch64/xray-attribute-instrumentation.ll
  llvm/test/CodeGen/AArch64/xray-tail-call-sled.ll
  llvm/test/CodeGen/PowerPC/xray-attribute-instrumentation.ll
  llvm/test/CodeGen/PowerPC/xray-tail-call-sled.ll
  llvm/test/CodeGen/X86/xray-attribute-instrumentation.ll
  llvm/test/CodeGen/X86/xray-log-args.ll
  llvm/test/CodeGen/X86/xray-partial-instrumentation-skip-entry.ll
  llvm/test/CodeGen/X86/xray-tail-call-sled.ll

-------------- next part --------------
A non-text attachment was scrubbed...
Name: D152661.530351.patch
Type: text/x-patch
Size: 22476 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20230611/fea9b8f6/attachment.bin>


More information about the llvm-commits mailing list