[PATCH] D152567: [InstCombine] Add tests for (binop (binop (lshift X,Amt),Mask),(lshift Y,Amt)); NFC

[Nikita Popov via Phabricator via llvm-commits]

nikic added a comment.

I think we're missing some test coverage for different opcode combinations here. I'm not sure if need to test all 46 valid opcode combinations, but I think we at least need more coverage for the invalid combinations. Things like `lshr` + `add` on binop1/binop2 etc.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D152567/new/

https://reviews.llvm.org/D152567