[llvm] 2509c93 - [Transforms] Remove AddDiscriminatorsLegacyPass

Kazu Hirata via llvm-commits llvm-commits at lists.llvm.org
Sat Jun 10 15:32:54 PDT 2023


Author: Kazu Hirata
Date: 2023-06-10T15:32:47-07:00
New Revision: 2509c93edd36a20a0aeb5e6d612dae5b770bc987

URL: https://github.com/llvm/llvm-project/commit/2509c93edd36a20a0aeb5e6d612dae5b770bc987
DIFF: https://github.com/llvm/llvm-project/commit/2509c93edd36a20a0aeb5e6d612dae5b770bc987.diff

LOG: [Transforms] Remove AddDiscriminatorsLegacyPass

The last use was removed by:

  commit ae0987d242e266847f21f5fa1bffa97ce3eff586
  Author: Kazu Hirata <kazu at google.com>
  Date:   Sat Jun 10 13:51:35 2023 -0700

Differential Revision: https://reviews.llvm.org/D152636

Added: 
    

Modified: 
    llvm/include/llvm/InitializePasses.h
    llvm/lib/Transforms/Utils/AddDiscriminators.cpp
    llvm/lib/Transforms/Utils/Utils.cpp

Removed: 
    


################################################################################
diff  --git a/llvm/include/llvm/InitializePasses.h b/llvm/include/llvm/InitializePasses.h
index 51953cdccea01..4159aed7ece24 100644
--- a/llvm/include/llvm/InitializePasses.h
+++ b/llvm/include/llvm/InitializePasses.h
@@ -51,7 +51,6 @@ void initializeTarget(PassRegistry&);
 void initializeAAEvalLegacyPassPass(PassRegistry&);
 void initializeAAResultsWrapperPassPass(PassRegistry&);
 void initializeADCELegacyPassPass(PassRegistry&);
-void initializeAddDiscriminatorsLegacyPassPass(PassRegistry&);
 void initializeAlwaysInlinerLegacyPassPass(PassRegistry&);
 void initializeAssignmentTrackingAnalysisPass(PassRegistry &);
 void initializeAssumeBuilderPassLegacyPassPass(PassRegistry &);

diff  --git a/llvm/lib/Transforms/Utils/AddDiscriminators.cpp b/llvm/lib/Transforms/Utils/AddDiscriminators.cpp
index 9a4deade0b8fc..7d127400651ef 100644
--- a/llvm/lib/Transforms/Utils/AddDiscriminators.cpp
+++ b/llvm/lib/Transforms/Utils/AddDiscriminators.cpp
@@ -85,28 +85,6 @@ static cl::opt<bool> NoDiscriminators(
     "no-discriminators", cl::init(false),
     cl::desc("Disable generation of discriminator information."));
 
-namespace {
-
-// The legacy pass of AddDiscriminators.
-struct AddDiscriminatorsLegacyPass : public FunctionPass {
-  static char ID; // Pass identification, replacement for typeid
-
-  AddDiscriminatorsLegacyPass() : FunctionPass(ID) {
-    initializeAddDiscriminatorsLegacyPassPass(*PassRegistry::getPassRegistry());
-  }
-
-  bool runOnFunction(Function &F) override;
-};
-
-} // end anonymous namespace
-
-char AddDiscriminatorsLegacyPass::ID = 0;
-
-INITIALIZE_PASS_BEGIN(AddDiscriminatorsLegacyPass, "add-discriminators",
-                      "Add DWARF path discriminators", false, false)
-INITIALIZE_PASS_END(AddDiscriminatorsLegacyPass, "add-discriminators",
-                    "Add DWARF path discriminators", false, false)
-
 static bool shouldHaveDiscriminator(const Instruction *I) {
   return !isa<IntrinsicInst>(I) || isa<MemIntrinsic>(I);
 }
@@ -264,10 +242,6 @@ static bool addDiscriminators(Function &F) {
   return Changed;
 }
 
-bool AddDiscriminatorsLegacyPass::runOnFunction(Function &F) {
-  return addDiscriminators(F);
-}
-
 PreservedAnalyses AddDiscriminatorsPass::run(Function &F,
                                              FunctionAnalysisManager &AM) {
   if (!addDiscriminators(F))

diff  --git a/llvm/lib/Transforms/Utils/Utils.cpp b/llvm/lib/Transforms/Utils/Utils.cpp
index 401bbe2dbea41..91c743f177641 100644
--- a/llvm/lib/Transforms/Utils/Utils.cpp
+++ b/llvm/lib/Transforms/Utils/Utils.cpp
@@ -21,7 +21,6 @@ using namespace llvm;
 /// initializeTransformUtils - Initialize all passes in the TransformUtils
 /// library.
 void llvm::initializeTransformUtils(PassRegistry &Registry) {
-  initializeAddDiscriminatorsLegacyPassPass(Registry);
   initializeAssumeBuilderPassLegacyPassPass(Registry);
   initializeBreakCriticalEdgesPass(Registry);
   initializeCanonicalizeFreezeInLoopsPass(Registry);


        


More information about the llvm-commits mailing list