[PATCH] D152067: [ConstraintElimination] Handle equality predicates

[Antonio Frighetto via Phabricator via llvm-commits]

antoniofrighetto added inline comments.


================
Comment at: llvm/test/Transforms/ConstraintElimination/reproducer-remarks-debug.ll:12
 ; CHECK-NEXT:   Materializing assumption   %c.1 = icmp eq ptr %a, null
-; CHECK-NEXT: ---
 
----------------
fhahn wrote:
> What changed here?
There is a leftover (`---`) for the current implementation, as even when `IsConditionImplied` is true, `isConditionImplied(Negated)` is computed, leading to the following debug output:
```
---
%a + -1 * null <= 0
%a + -1 * null <= 0
sat
```
This doesn't occur anymore now, as, for the general case, we do not compute `IsNegatedImplied` when `IsConditionImplied` is true.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D152067/new/

https://reviews.llvm.org/D152067