[PATCH] D152538: `G_ATOMICRMW_NAND` failure in legalizer

[Matt Arsenault via Phabricator via llvm-commits]

arsenm added inline comments.


================
Comment at: llvm/unittests/CodeGen/GlobalISel/LegalizerHelperTest.cpp:4198
+
+  auto MIBAtomicRMWNand = B.buildAtomicRMWNand(OldValRes, Addr, Val, *MMO);
+
----------------
niwinanto wrote:
> arsenm wrote:
> > niwinanto wrote:
> > > arsenm wrote:
> > > > can just specify the return type here
> > > You meant `auto MIBAtomicRMWNand` to `MachineInstrBuilder MIBAtomicRMWNand`, or?
> > auto Nand = B.buildAtomicRMW(LLT::scalar(32))
> I don't get the issue with `buildAtomicRMWNand`
You do not need to pre-create the register. You can pass the type like you did with buildConstant above


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D152538/new/

https://reviews.llvm.org/D152538