[PATCH] D152613: [AMDGPU] Remove integer division in VOPD checks

[Stanislav Mekhanoshin via Phabricator via llvm-commits]

rampitec added inline comments.


================
Comment at: llvm/lib/Target/AMDGPU/Utils/AMDGPUBaseInfo.h:564
-// Number of VGPR banks per VOPD component operand.
-constexpr unsigned BANKS_NUM[] = {2, 4, 4, 2};
 
----------------
rampitec wrote:
> On a separate note, I do not understand 2 banks for the src2. This should have been checked yet while checking vdst parity. If there is a real src2 it must follow a regular rules for the source banks. At the moment this is simply misleading, the loop will actually exit at the first iteration if the parity is the same. It is a time bomb, but this is a separate patch.
In fact this is already broken: D152614. Our own tests verify this is broken and must be broken. Insane.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D152613/new/

https://reviews.llvm.org/D152613