[PATCH] D152499: [SCCP] Skip computing intrinsics if one of its args is unknownOrUndef

[luxufan via Phabricator via llvm-commits]

StephenFan updated this revision to Diff 530178.
StephenFan added a comment.

Precommit test and rebase.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D152499/new/

https://reviews.llvm.org/D152499

Files:
  llvm/lib/Transforms/Utils/SCCPSolver.cpp
  llvm/test/Transforms/SCCP/intrinsics.ll


Index: llvm/test/Transforms/SCCP/intrinsics.ll
===================================================================
--- llvm/test/Transforms/SCCP/intrinsics.ll
+++ llvm/test/Transforms/SCCP/intrinsics.ll
@@ -107,8 +107,7 @@
 ; CHECK:       false:
 ; CHECK-NEXT:    br label [[EXIT]]
 ; CHECK:       exit:
-; CHECK-NEXT:    [[P_UMAX:%.*]] = call i8 @llvm.umax.i8(i8 3, i8 1)
-; CHECK-NEXT:    ret i8 [[P_UMAX]]
+; CHECK-NEXT:    ret i8 3
 ;
   br i1 %c.1, label %true, label %false
 
Index: llvm/lib/Transforms/Utils/SCCPSolver.cpp
===================================================================
--- llvm/lib/Transforms/Utils/SCCPSolver.cpp
+++ llvm/lib/Transforms/Utils/SCCPSolver.cpp
@@ -1779,6 +1779,8 @@
       SmallVector<ConstantRange, 2> OpRanges;
       for (Value *Op : II->args()) {
         const ValueLatticeElement &State = getValueState(Op);
+        if (State.isUnknownOrUndef())
+          return;
         OpRanges.push_back(getConstantRange(State, Op->getType()));
       }
 


-------------- next part --------------
A non-text attachment was scrubbed...
Name: D152499.530178.patch
Type: text/x-patch
Size: 996 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20230610/21c4433a/attachment.bin>