[PATCH] D152585: [dsymutil] Skip duplicates files with identical time stamps in the debug map
Adrian Prantl via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Fri Jun 9 17:10:15 PDT 2023
aprantl added inline comments.
================
Comment at: llvm/tools/dsymutil/MachODebugMapParser.cpp:260
+ llvm::DenseSet<OSO> OSOs;
+ llvm::SmallSet<OSO, 4> Duplicates;
+
----------------
Maybe also use a DenseSet here? Once we're printing the warning the overhead for the memory allocation probably doesn't matter any more.
================
Comment at: llvm/tools/dsymutil/MachODebugMapParser.cpp:724
+ static inline MachODebugMapParser::OSO getTombstoneKey() {
+ return MachODebugMapParser::OSO("", 0);
+ }
----------------
Is it legal that Empty == Tombstone?
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D152585/new/
https://reviews.llvm.org/D152585
More information about the llvm-commits
mailing list