[PATCH] D152456: SeparateConstOffsetFromGEP: Preserve SCEV

[Nikita Popov via Phabricator via llvm-commits]

nikic added a comment.

I think this is okay, but I just took a look at what this pass actually does with SCEV and ... wat.

As far as I can tell, SCEV here can be replaced by using a `std::pair<Value *, Value *>` instead of a SCEV expressions in the DominatingAdd/DominatingSub maps. Might be better to do that and not request SCEV at all?


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D152456/new/

https://reviews.llvm.org/D152456