[PATCH] D152541: [InstCombine] Remove swapMayExposeCSEOpportunities() fold

[Nikita Popov via Phabricator via llvm-commits]

nikic planned changes to this revision.
nikic added a comment.

In D152541#4409284 <https://reviews.llvm.org/D152541#4409284>, @RKSimon wrote:

> Looks like this landed all the way back at rG5ab555532b5a <https://reviews.llvm.org/rG5ab555532b5aaee281bded6341e240d3bc6261df> - are the cse tests in icmp.ll still relevant?

Okay, based on the commit description this is targeted at cross-BB cases, which SDAG doesn't handle. And indeed, something like this survives all the way through the backend: https://llvm.godbolt.org/z/TzT3rEehe I think in that case we can't drop this entirely and should move it from InstCombine into CGP instead.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D152541/new/

https://reviews.llvm.org/D152541