[PATCH] D128059: [Clang] Add a warning on invalid UTF-8 in comments.
Tom Honermann via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Fri Jun 9 12:10:11 PDT 2023
tahonermann added a comment.
@cor3ntin, sorry for failing to keep up with reviews; I know this has already been committed. I did spot a couple of typos should you feel inclined to address them.
================
Comment at: clang/lib/Lex/Lexer.cpp:2695
+ // diagnostic only once per entire ill-formed subsequence to avoid
+ // emiting to many diagnostics (see http://unicode.org/review/pr-121.html).
+ bool UnicodeDecodingAlreadyDiagnosed = false;
----------------
================
Comment at: clang/lib/Lex/Lexer.cpp:2398
+ // diagnostic only once per entire ill-formed subsequence to avoid
+ // emiting to many diagnostics (see http://unicode.org/review/pr-121.html).
+ bool UnicodeDecodingAlreadyDiagnosed = false;
----------------
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D128059/new/
https://reviews.llvm.org/D128059
More information about the llvm-commits
mailing list