[PATCH] D149848: [AArch64, compiler-rt] Implement trampoline intrinsics
Saleem Abdulrasool via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Fri Jun 9 11:01:28 PDT 2023
compnerd added inline comments.
================
Comment at: llvm/lib/Target/AArch64/AArch64ISelLowering.cpp:5776
+ report_fatal_error("trampoline intrinsics are "
+ "not supported on this platform.");
+
----------------
Is this intrinsic available in GCC? When was it added there? This could be an ABI break otherwise. We should check the runtime that we are going to link against before lowering this I think.
================
Comment at: llvm/test/CodeGen/AArch64/trampoline.ll:35
+}
+
----------------
Could you add negative checks for the other platforms please?
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D149848/new/
https://reviews.llvm.org/D149848
More information about the llvm-commits
mailing list