[PATCH] D152261: [CodeGen] Move lowerCopy from expandPostRA to TII

Matt Arsenault via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Fri Jun 9 10:19:59 PDT 2023


arsenm added inline comments.


================
Comment at: llvm/include/llvm/CodeGen/TargetInstrInfo.h:1164
+  /// This function defines the logic to lower COPY instruction to
+  /// machine IR.
+  bool lowerCopy(MachineInstr *MI) const;
----------------
barannikov88 wrote:
> cdevadas wrote:
> > Fix the comment  "machine IR" -> "target specific instruction"
> Can't it be lowered into several instructions? The comment near copyPhysReg suggests that it can.
> 
Yes, most copies are expanded to multiple instructions for amdgpu


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D152261/new/

https://reviews.llvm.org/D152261



More information about the llvm-commits mailing list