[PATCH] D152557: [AMDGPU][GFX11] Add test coverage for cases involving conversions from and to fp16 values.

Joe Nash via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Fri Jun 9 10:17:20 PDT 2023


Joe_Nash added inline comments.


================
Comment at: llvm/test/CodeGen/AMDGPU/amdgcn.bitcast.ll:1
-; RUN: llc -march=amdgcn -verify-machineinstrs < %s | FileCheck -check-prefix=SI -check-prefix=FUNC %s
-; RUN: llc -march=amdgcn -mcpu=tonga -verify-machineinstrs < %s | FileCheck -check-prefix=SI -check-prefix=FUNC %s
-; RUN: llc -march=amdgcn -mcpu=gfx900 -verify-machineinstrs < %s | FileCheck -check-prefix=SI -check-prefix=FUNC %s
+; RUN: llc -march=amdgcn -verify-machineinstrs < %s | FileCheck -check-prefix=GCN %s
+; RUN: llc -march=amdgcn -mcpu=tonga -verify-machineinstrs < %s | FileCheck -check-prefix=GCN %s
----------------
I believe the GCN name is outdated, and we shouldn't introduce more usages of it. It seems fine to make this CHECK or leave it FUNC


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D152557/new/

https://reviews.llvm.org/D152557



More information about the llvm-commits mailing list