[PATCH] D152556: [FuncSpec] Promote stack values before specialization

Fri Jun 9 10:03:52 PDT 2023

mtsamis added a comment.

In D152556#4409234 <https://reviews.llvm.org/D152556#4409234>, @chill wrote:

> In https://reviews.llvm.org/D145819 this is done for each iteration, IIRC so the same transformation can  be applied to the new specialised instances.

Thanks for the reference.

I see this moves `promoteConstantStackValues()` to the beggining of `run` which means that one the last iteration `promoteConstantStackValues` is not called.
This can result in some extra unpromoted / unwanted instructions after the specializer, which can be seen when funcspec-max-iters is not very large.
That's why I opted for calling it both initially and then after each iteration.

Would it be worthwhile to suggest merging this with the code on https://reviews.llvm.org/D145819?

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D152556/new/

https://reviews.llvm.org/D152556