[PATCH] D152513: [SCEV] Use isKnownNonZero() for SCEV verification

[Noah Goldstein via Phabricator via llvm-commits]

goldstein.w.n added inline comments.


================
Comment at: llvm/lib/Analysis/ScalarEvolution.cpp:14055
+    // the same. In VerifySCEVStrict mode, report cases where we cannot prove
+    // that the expressions are the same.
+    if (VerifySCEVStrict ? !Delta->isZero() : SE2.isKnownNonZero(Delta))
----------------
I don't quite understand the new comment for "In VerifySCEVStrict mode...". Before it was clear; constants only. I don't see how `!Delta->isZero()` implies we are unable prove the expressions are the same but `isKnownNonZero(Delta)` doesn't.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D152513/new/

https://reviews.llvm.org/D152513