[PATCH] D152546: [Pseudo Probe] Placing .pseudoprobe section in a comdat group

[Hongtao Yu via Phabricator via llvm-commits]

hoy created this revision.
Herald added subscribers: wlei, modimo, wenlei, hiraditya.
Herald added a project: All.
hoy requested review of this revision.
Herald added a project: LLVM.
Herald added a subscriber: llvm-commits.

Previously the .pseudoprobe data section of a function was supposed to be placed in its own comdat group so that it can de deduplicated against same-named data (such as weak symbols). Unfortunately a bug in the group name setting blocked such, therefore probes for different copies of the same function were not deduplicated and duplicated probes were reported for the final binary code. I'm fixing the bug to unblock the deduplication.

This saves 1.5% of the size of .pseudo_probe section for one of Meta's internal large workload.


Repository:
  rG LLVM Github Monorepo

https://reviews.llvm.org/D152546

Files:
  llvm/include/llvm/MC/MCObjectFileInfo.h
  llvm/lib/MC/MCObjectFileInfo.cpp
  llvm/lib/MC/MCPseudoProbe.cpp
  llvm/test/Transforms/SampleProfile/pseudo-probe-emit.ll

-------------- next part --------------
A non-text attachment was scrubbed...
Name: D152546.529981.patch
Type: text/x-patch
Size: 4966 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20230609/c6097004/attachment.bin>