[PATCH] D152536: [DWARF] Allow op-index in line number programs

David Stenberg via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Fri Jun 9 07:00:58 PDT 2023


dstenb created this revision.
dstenb added reviewers: jhenderson, probinson, MaskRay.
dstenb added a project: debug-info.
Herald added subscribers: luke, frasercrmck, cmtice, luismarques, apazos, sameer.abuasal, s.egerton, Jim, jocewei, PkmX, arphaman, the_o, brucehoult, MartinMosbeck, rogfer01, edward-jones, zzheng, jrtc27, niosHD, sabuasal, simoncook, johnrusso, rbar, asb, hiraditya, emaste.
Herald added a project: All.
dstenb requested review of this revision.
Herald added subscribers: llvm-commits, pcwang-thead.
Herald added a project: LLVM.

This extends DWARFDebugLine to properly parse line number programs with
maximum_operations_per_instruction > 1 for VLIW targets.

No functions that use that parsed output to retrieve line information
have been extended to support multiple op-indexes. This means that when
retrieving information for an address with multiple op-indexes, e.g.
when using llvm-addr2line, the penultimate row for that address will be
used, which in most cases is the row for the second largest op-index.
This will be addressed in further changes, but this patch at least
allows us to correctly parse line number programs with op-indexes
without any errors.


Repository:
  rG LLVM Github Monorepo

https://reviews.llvm.org/D152536

Files:
  llvm/include/llvm/DebugInfo/DWARF/DWARFDebugLine.h
  llvm/lib/DebugInfo/DWARF/DWARFDebugLine.cpp
  llvm/test/MC/ELF/RISCV/gen-dwarf.s
  llvm/test/tools/llvm-dwarfdump/X86/tombstone.s
  llvm/test/tools/llvm-dwarfdump/X86/verbose.test
  llvm/unittests/DebugInfo/DWARF/DWARFDebugLineTest.cpp

-------------- next part --------------
A non-text attachment was scrubbed...
Name: D152536.529951.patch
Type: text/x-patch
Size: 25259 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20230609/8c912463/attachment.bin>


More information about the llvm-commits mailing list