[PATCH] D152483: [BOLT][NFCI] Use StringRef.split in launchPerfProcess
Amir Ayupov via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Fri Jun 9 06:24:27 PDT 2023
This revision was automatically updated to reflect the committed changes.
Closed by commit rG5acac7db6e71: [BOLT][NFCI] Use StringRef.split in launchPerfProcess (authored by Amir).
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D152483/new/
https://reviews.llvm.org/D152483
Files:
bolt/lib/Profile/DataAggregator.cpp
Index: bolt/lib/Profile/DataAggregator.cpp
===================================================================
--- bolt/lib/Profile/DataAggregator.cpp
+++ bolt/lib/Profile/DataAggregator.cpp
@@ -216,17 +216,7 @@
outs() << "PERF2BOLT: spawning perf job to read " << Name << '\n';
Argv.push_back(PerfPath.data());
- char *WritableArgsString = strdup(ArgsString);
- char *Str = WritableArgsString;
- do {
- Argv.push_back(Str);
- while (*Str && *Str != ' ')
- ++Str;
- if (!*Str)
- break;
- *Str++ = 0;
- } while (true);
-
+ StringRef(ArgsString).split(Argv, ' ');
Argv.push_back("-f");
Argv.push_back("-i");
Argv.push_back(Filename.c_str());
@@ -266,8 +256,6 @@
else
PPI.PI = sys::ExecuteNoWait(PerfPath.data(), Argv, /*envp*/ std::nullopt,
Redirects);
-
- free(WritableArgsString);
}
void DataAggregator::processFileBuildID(StringRef FileBuildID) {
-------------- next part --------------
A non-text attachment was scrubbed...
Name: D152483.529943.patch
Type: text/x-patch
Size: 938 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20230609/9908aa51/attachment.bin>
More information about the llvm-commits
mailing list