[PATCH] D152067: [ConstraintElimination] Handle equality predicates

Fri Jun 9 05:26:59 PDT 2023

fhahn added a comment.

In D152067#4408002 <https://reviews.llvm.org/D152067#4408002>, @antoniofrighetto wrote:

> 

> in `checkAndReplaceCondition`, as we would still need to compute the negated separately (`reproducer-remarks-debug.ll` seems to be complaining). Perhaps we slightly lose some of the clarity / self-documenting that comes with distinguishing between `EqualityTrue`, `ConditionTrue` (may assist in debugging), though, likewise, that shouldn't be really that much of a problem. Could that work?

I am not sure why we would need to compute the negation separately? Wouldn't `ConditionHoldFalse` cover exactly the case where the negated condition holds?

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D152067/new/

https://reviews.llvm.org/D152067