[PATCH] D150388: [CodeGen]Allow targets to use target specific COPY instructions for live range splitting

Yashwant Singh via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Fri Jun 9 05:03:32 PDT 2023


yassingh marked 3 inline comments as done.
yassingh added inline comments.


================
Comment at: llvm/lib/CodeGen/InlineSpiller.cpp:830
 
-  bool WasCopy = MI->isCopy();
+  bool WasCopy = TII.isCopyInstr(*MI) ? true : false;
   Register ImpReg;
----------------
arsenm wrote:
> Don't need ? true : false
isCopyInstr() returns std::optional. Should I use 'auto' to get rid of the ternary operator?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D150388/new/

https://reviews.llvm.org/D150388



More information about the llvm-commits mailing list