[PATCH] D152059: [AVR] Replace shift-to-loop IR pass with common shift code

Ben Shi via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Fri Jun 9 01:39:09 PDT 2023


benshi001 added inline comments.


================
Comment at: llvm/lib/Target/AVR/AVRISelLowering.cpp:2229
+        .addMBB(LoopBB);
+    Regs[I] = std::pair(PhiRegs[I], 0);
+  }
----------------
After this line, how is the field `second` of `Regs[I]` set to `sub_lo` or `sub_hi`? Would it be better to

```
Regs[I] = PhiRegPairs[I];
```

?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D152059/new/

https://reviews.llvm.org/D152059



More information about the llvm-commits mailing list