[PATCH] D152484: [KCFI] Fix hash offset calculation in Thumb mode

Simon Tatham via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Fri Jun 9 01:10:23 PDT 2023


simon_tatham accepted this revision.
simon_tatham added a comment.

Thanks! This should fix https://github.com/llvm/llvm-project/issues/62936.

I agree that it's better to do the fix here, instead of adding dedicated support in the backend the way AArch64 does it, because as far as I can see backend KCFI checks are inserted after register allocation and have to use registers that are already dead. And in at least one Arm situation (namely Armv6-M) no such registers are //conveniently// available, so the check would become more expensive.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D152484/new/

https://reviews.llvm.org/D152484



More information about the llvm-commits mailing list