[PATCH] D121187: [DAGCombiner][VP] Add DAGCombine for VP_MUL.

Jianjian Guan via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Fri Jun 9 00:15:05 PDT 2023


jacquesguan marked 2 inline comments as done.
jacquesguan added inline comments.


================
Comment at: llvm/lib/CodeGen/SelectionDAG/DAGCombiner.cpp:4282
   // fold (mul c1, c2) -> c1*c2
+  // TODO: Improve FoldConstantArithmetic to support vp ops.
   if (SDValue C = DAG.FoldConstantArithmetic(ISD::MUL, DL, VT, {N0, N1}))
----------------
craig.topper wrote:
> What does it mean to support a VP op in FoldConstantArithmetic?
I was thinking wrong. This TODO is removed now.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D121187/new/

https://reviews.llvm.org/D121187



More information about the llvm-commits mailing list