[PATCH] D152441: [SLPVectorizer] Don't include debug instructions in ScheduleRegionSize

[Mikael Holmén via Phabricator via llvm-commits]

uabelho added a comment.

In D152441#4405841 <https://reviews.llvm.org/D152441#4405841>, @jmorse wrote:

> Many thanks for the patch, it looks good to me although I'm not very familiar with the vectorisers -- if no-one else reviews deeply then I can give it a shot later,
>
> Would it be simpler to replace the increment lines with calls to `getNextNonDebugInstruction` rather than add a new predicate / set of calls -- this has the benefit of being slightly smaller, and will make cleanup easier once we've suppressed debug intrinsics entirely,

I don't know. The searches use both forward and reverse iterators, I thought changing to getNextNonDebugInstruction/getPrevNonDebugInstruction would make the change larger since I guess I'd have to get rid of the reverse iterator then (?) and since I'm not familiar with this code I tried keeping the change as small as possible to not risk messing things up.

But I can try to go that route again if we prefer that.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D152441/new/

https://reviews.llvm.org/D152441