[PATCH] D152298: [RISCV] Use vslidedown.vi vN, vN, 0 instead of vslideup.vi vN, vM, 0 for subvector insertion

Craig Topper via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Thu Jun 8 22:25:38 PDT 2023


craig.topper added inline comments.


================
Comment at: llvm/lib/Target/RISCV/RISCVISelLowering.cpp:7367
 
   SDValue Slideup = getVSlideup(DAG, Subtarget, DL, InterSubVT, AlignedExtract,
                                 SubVec, SlideupAmt, Mask, VL);
----------------
craig.topper wrote:
> Should we do the same thing here? Would that catch the cases the patch from @luke gets?
Posted that change as https://reviews.llvm.org/D152496


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D152298/new/

https://reviews.llvm.org/D152298



More information about the llvm-commits mailing list