[PATCH] D121187: [DAGCombiner][VP] Add DAGCombine for VP_MUL.

[Craig Topper via Phabricator via llvm-commits]

craig.topper added inline comments.


================
Comment at: llvm/lib/CodeGen/SelectionDAG/DAGCombiner.cpp:4274
   SDLoc DL(N);
+  bool ISVP = ISD::isVPOpcode(N->getOpcode());
+  MatchContextClass matcher(DAG, TLI, N);
----------------
IS -> Is


================
Comment at: llvm/lib/CodeGen/SelectionDAG/DAGCombiner.cpp:4282
   // fold (mul c1, c2) -> c1*c2
+  // TODO: Improve FoldConstantArithmetic to support vp ops.
   if (SDValue C = DAG.FoldConstantArithmetic(ISD::MUL, DL, VT, {N0, N1}))
----------------
What does it mean to support a VP op in FoldConstantArithmetic?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D121187/new/

https://reviews.llvm.org/D121187