[PATCH] D151782: Improve WebAssembly vector bitmask, mask reduction, and extending

Caleb Zulawski via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Thu Jun 8 17:36:25 PDT 2023


calebzulawski updated this revision to Diff 529789.
calebzulawski added a comment.

Since this has been reverted, I'm just updating the complete patch here.

All I changed was allowing unexpected vector lengths to lower as usual.  Codegen for unusual vector lengths is still very bad--there should be an additional step somewhere that breaks up bitcasts to legal vector lengths (the X86 codegen does this before MOVMSK, but I can't figure out how).


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D151782/new/

https://reviews.llvm.org/D151782

Files:
  llvm/lib/Target/WebAssembly/WebAssemblyISelLowering.cpp
  llvm/lib/Target/WebAssembly/WebAssemblyISelLowering.h
  llvm/test/CodeGen/WebAssembly/simd-bitmask.ll
  llvm/test/CodeGen/WebAssembly/simd-extending-convert.ll
  llvm/test/CodeGen/WebAssembly/simd-extending.ll
  llvm/test/CodeGen/WebAssembly/simd-offset.ll
  llvm/test/CodeGen/WebAssembly/simd-vecreduce-bool.ll

-------------- next part --------------
A non-text attachment was scrubbed...
Name: D151782.529789.patch
Type: text/x-patch
Size: 51738 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20230609/d62acb27/attachment.bin>


More information about the llvm-commits mailing list