[PATCH] D149842: Scalarizer: limit scalarization for small element types

[Matt Arsenault via Phabricator via llvm-commits]

arsenm accepted this revision.
arsenm added a comment.

LGTM with nit.

Also a TTI control and / or pass parameter would be better than cl::opt



================
Comment at: llvm/lib/Transforms/Scalar/Scalarizer.cpp:220
+/// described in @p VS.
+static Value *concatenate(IRBuilder<> &Builder, ArrayRef<Value *> Fragments,
+                          const VectorSplit &VS, Twine Name) {
----------------
I swear this function exists somewhere else but I can't seem to find it


================
Comment at: llvm/lib/Transforms/Scalar/Scalarizer.cpp:409
+                                        V->getType()->getPointerAddressSpace());
+      CV[Frag] = Builder.CreateBitCast(CV[Frag], NewPtrTy);
+    }
----------------
Don't need pointer bitcast anymore


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D149842/new/

https://reviews.llvm.org/D149842