[PATCH] D152397: GlobalISel: Remove block insertion legalizer check

Matt Arsenault via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Thu Jun 8 14:59:15 PDT 2023

arsenm added a comment.

In D152397#4406862 <https://reviews.llvm.org/D152397#4406862>, @aemerson wrote:

> If we get a different number of blocks, can we instead check that the blocks have been legalized? If we get unlegalized instruction failures at selection time, it'll be confusing if the root cause is this.

I basically see no value in trying to catch this with a special case fallback. First I don't actually know if the blocks will be missed, I'm just assuming. Anything attempted here is just going to be bug ridden and probably won't actually work, like this check didn't. I also don't think debugging that will be that difficult for whenever other block splitting legalizations are added



More information about the llvm-commits mailing list