[PATCH] D147116: [RFC] Introduce convergence control intrinsics

[Matt Arsenault via Phabricator via llvm-commits]

arsenm added inline comments.


================
Comment at: llvm/lib/IR/Verifier.cpp:2559
+  for (BasicBlock *BB : RPOT) {
+    SmallVector<CallBase *, 8> LiveTokens;
+    auto LTIt = LiveTokenMap.find(BB);
----------------
Don't reconstruct each iteration?


================
Comment at: llvm/lib/IR/Verifier.cpp:2574
+      auto Bundle = CB->getOperandBundle(LLVMContext::OB_convergencectrl);
+      if (Bundle) {
+        Check(Bundle->Inputs.size() == 1 &&
----------------
This is a pretty long and indented block, move to helper function?


================
Comment at: llvm/lib/IR/Verifier.cpp:2629
+    // Propagate token liveness
+    for (BasicBlock *Succ : llvm::successors(BB)) {
+      DomTreeNode *SuccNode = DT.getNode(Succ);
----------------
Don't need llvm::


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D147116/new/

https://reviews.llvm.org/D147116