[llvm] 6540157 - [llvm-dlltool] Ignore the --temp-prefix option

[Martin Storsjö via llvm-commits]

Author: Martin Storsjö
Date: 2023-06-08T23:21:56+03:00
New Revision: 6540157fe389b3dc46e9a1306370acd79d40c183

URL: https://github.com/llvm/llvm-project/commit/6540157fe389b3dc46e9a1306370acd79d40c183
DIFF: https://github.com/llvm/llvm-project/commit/6540157fe389b3dc46e9a1306370acd79d40c183.diff

LOG: [llvm-dlltool] Ignore the --temp-prefix option

llvm-dlltool tolerates unknown options as long as they are plain
flags, but if given the parameter value as a separate argument,
e.g. "--temp-prefix foo", it fails to ignore it.

Differential Revision: https://reviews.llvm.org/D152361

Added: 
    llvm/test/tools/llvm-dlltool/ignored-opts.def

Modified: 
    llvm/lib/ToolDrivers/llvm-dlltool/Options.td

Removed: 
    


################################################################################
diff  --git a/llvm/lib/ToolDrivers/llvm-dlltool/Options.td b/llvm/lib/ToolDrivers/llvm-dlltool/Options.td
index e78182ab8130b..6da5dc8f5814e 100644
--- a/llvm/lib/ToolDrivers/llvm-dlltool/Options.td
+++ b/llvm/lib/ToolDrivers/llvm-dlltool/Options.td
@@ -24,3 +24,6 @@ def S_alias: JoinedOrSeparate<["--"], "as">, Alias<S>;
 
 def f: JoinedOrSeparate<["-"], "f">, HelpText<"Assembler Flags">;
 def f_alias: JoinedOrSeparate<["--"], "as-flags">, Alias<f>;
+
+def t: JoinedOrSeparate<["-"], "t">, HelpText<"Prefix for temporary files (ignored)">;
+def t_alias: JoinedOrSeparate<["--"], "temp-prefix">, Alias<t>;

diff  --git a/llvm/test/tools/llvm-dlltool/ignored-opts.def b/llvm/test/tools/llvm-dlltool/ignored-opts.def
new file mode 100644
index 0000000000000..6cc05e376d31b
--- /dev/null
+++ b/llvm/test/tools/llvm-dlltool/ignored-opts.def
@@ -0,0 +1,8 @@
+; RUN: llvm-dlltool -m i386 -d %s -l %t.a --temp-prefix foo
+; RUN: llvm-dlltool -m i386 -d %s -l %t.a --temp-prefix=foo
+; RUN: llvm-dlltool -m i386 -d %s -l %t.a -t foo
+; RUN: llvm-dlltool -m i386 -d %s -l %t.a -tfoo
+
+LIBRARY test.dll
+EXPORTS
+TestFunction