[llvm] 9080f61 - [COFF] Remove misleading and unclear comments. NFC.
Martin Storsjö via llvm-commits
llvm-commits at lists.llvm.org
Thu Jun 8 13:22:28 PDT 2023
Author: Martin Storsjö
Date: 2023-06-08T23:21:56+03:00
New Revision: 9080f619461f3d68c8126dcde7c6f95dbae75347
URL: https://github.com/llvm/llvm-project/commit/9080f619461f3d68c8126dcde7c6f95dbae75347
DIFF: https://github.com/llvm/llvm-project/commit/9080f619461f3d68c8126dcde7c6f95dbae75347.diff
LOG: [COFF] Remove misleading and unclear comments. NFC.
It is not planned that GNU binutils would change this aspect of
its behaviour wrt how symbol decoration is done.
Differential Revision: https://reviews.llvm.org/D152359
Added:
Modified:
llvm/include/llvm/Object/COFFModuleDefinition.h
Removed:
################################################################################
diff --git a/llvm/include/llvm/Object/COFFModuleDefinition.h b/llvm/include/llvm/Object/COFFModuleDefinition.h
index 8e14dd61472d7..c9d8f428993c5 100644
--- a/llvm/include/llvm/Object/COFFModuleDefinition.h
+++ b/llvm/include/llvm/Object/COFFModuleDefinition.h
@@ -39,9 +39,6 @@ struct COFFModuleDefinition {
uint32_t MinorOSVersion = 0;
};
-// mingw and wine def files do not mangle _ for x86 which
-// is a consequence of legacy binutils' dlltool functionality.
-// This MingwDef flag should be removed once mingw stops this pratice.
Expected<COFFModuleDefinition>
parseCOFFModuleDefinition(MemoryBufferRef MB, COFF::MachineTypes Machine,
bool MingwDef = false);
More information about the llvm-commits
mailing list