[llvm] e5479f2 - [MemProf] Remove stale comment (NFC)

Teresa Johnson via llvm-commits llvm-commits at lists.llvm.org
Thu Jun 8 12:30:38 PDT 2023


Author: Teresa Johnson
Date: 2023-06-08T12:30:23-07:00
New Revision: e5479f27f20f397ab422ba072634affffa69e928

URL: https://github.com/llvm/llvm-project/commit/e5479f27f20f397ab422ba072634affffa69e928
DIFF: https://github.com/llvm/llvm-project/commit/e5479f27f20f397ab422ba072634affffa69e928.diff

LOG: [MemProf] Remove stale comment (NFC)

We already do the simplification described in the FIXME comment.

Added: 
    

Modified: 
    llvm/lib/Transforms/Utils/InlineFunction.cpp

Removed: 
    


################################################################################
diff  --git a/llvm/lib/Transforms/Utils/InlineFunction.cpp b/llvm/lib/Transforms/Utils/InlineFunction.cpp
index a433c83a7768f..dd5380b590989 100644
--- a/llvm/lib/Transforms/Utils/InlineFunction.cpp
+++ b/llvm/lib/Transforms/Utils/InlineFunction.cpp
@@ -875,9 +875,6 @@ static void propagateMemProfHelper(const CallBase *OrigCall,
 // inlined callee's callsite metadata with that of the inlined call,
 // and moving the subset of any memprof contexts to the inlined callee
 // allocations if they match the new inlined call stack.
-// FIXME: Replace memprof metadata with function attribute if all MIB end up
-// having the same behavior. Do other context trimming/merging optimizations
-// too.
 static void
 propagateMemProfMetadata(Function *Callee, CallBase &CB,
                          bool ContainsMemProfMetadata,


        


More information about the llvm-commits mailing list