[PATCH] D152311: [RISCV] Merge RISCVMCInstLower.cpp into RISCVAsmPrinter.cpp.

Thu Jun 8 11:18:21 PDT 2023

craig.topper added a comment.

In D152311#4402292 <https://reviews.llvm.org/D152311#4402292>, @asb wrote:

> In D152311#4402018 <https://reviews.llvm.org/D152311#4402018>, @craig.topper wrote:
>
>> In D152311#4401941 <https://reviews.llvm.org/D152311#4401941>, @asb wrote:
>>
>>> This is definitely something I just copied from other backends and I like the idea of merging it. There is some value in uniformity with other backends though, so if other targets were dead set against ever considering something similar then perhaps we'd consider if it's better to stay matching everyone else.
>>
>> I think there's already inconsistency in the structure of the files. I surveyed some of the targets.
>> (snip)
>
> Thanks - I upgrade my view from supportive to _very_ supportive!

Anything else I need to do to move forward with this?

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D152311/new/

https://reviews.llvm.org/D152311