[PATCH] D152441: [SLPVectorizer] Don't include debug instructions in ScheduleRegionSize

[Alexey Bataev via Phabricator via llvm-commits]

ABataev added inline comments.


================
Comment at: llvm/test/Transforms/SLPVectorizer/X86/schedule_budget.ll:8
 ; Test if the budget for the scheduling region size works.
 ; We test with a reduced budget of 16 which should prevent vectorizing the loads.
 
----------------
bjope wrote:
> ABataev wrote:
> > bjope wrote:
> > > So this test case is kind of "broken" already on trunk?
> > > 
> > > (Looks like commit 352c46e70716061e99cae2009daddbfc78380fda changed this test in a way so that the first loads are vectorized even with a budget at 16.)
> > Not broken, just changed. You'd better to add a new test with budget limits and debug info.
> Just thinking that this comment, as well as the later comment about " ; Don't vectorize these loads.", seem to explain the expected outcome of the test. But then the CHECK:s seem to validate something else. That is confusing.
> 
> But maybe uabelho can just remove the RUN line with budget=16. One could just use budget=18 instead. As that also would show the debug-variance problem (e.g by pre-commit such a slightly modified test).
The comments need to be removed in the separate patch. Or budget limit adjusted, whatever. 


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D152441/new/

https://reviews.llvm.org/D152441