[PATCH] D152098: [MC] Add MCRegisterInfo::regunits for iteration over register units

Quentin Colombet via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Thu Jun 8 05:12:03 PDT 2023


qcolombet added a comment.

Had a glance at the patch and it looks generally good to me.
One comment below and work with @foad to address his comment.



================
Comment at: llvm/include/llvm/MC/MCRegisterInfo.h:315
+      unsigned Offset = RU >> RegUnitBits;
+      init(FirstRU, MCRI->DiffLists + Offset);
+    }
----------------
Could you refactor the code to share the implementation with `MCRegUnitIterator::MCRegUnitIterator`?
E.g., a static helper function.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D152098/new/

https://reviews.llvm.org/D152098



More information about the llvm-commits mailing list