[PATCH] D147408: [AMDGPU] Iterative scan implementation for atomic optimizer.
Matt Arsenault via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Thu Jun 8 04:31:51 PDT 2023
arsenm accepted this revision.
arsenm added a comment.
This revision is now accepted and ready to land.
LGTM with nit
================
Comment at: llvm/lib/Target/AMDGPU/AMDGPUAtomicOptimizer.cpp:578
+
+ return std::make_pair(OldValue, NewAccumulator);
+}
----------------
{OldValue, NewAccumulator}
================
Comment at: llvm/lib/Target/AMDGPU/AMDGPUAtomicOptimizer.cpp:797
+
+ std::initializer_list<DominatorTree::UpdateType> DTUpdates{
+ {DominatorTree::Insert, EntryBB, ComputeLoop},
----------------
You don't need std::initializer_list, you can just use std::array
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D147408/new/
https://reviews.llvm.org/D147408
More information about the llvm-commits
mailing list