[PATCH] D151047: [clang-format] Fix indentation for selective formatting.

Sedenion via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Thu Jun 8 00:51:52 PDT 2023

Sedeniono marked an inline comment as done.
Sedeniono added inline comments.

Comment at: clang/lib/Format/UnwrappedLineFormatter.cpp:169-170
   /// The indent in characters for each level.
+  /// It remembers the indent of previous lines (that are not PP directives) of
+  /// equal or lower levels. This is used to align formatted lines to the indent
Sedeniono wrote:
> HazardyKnusperkeks wrote:
> > And then reformat the comment.
> Done.
Mh, it says [that it couldn't apply the patch](https://reviews.llvm.org/harbormaster/build/367648/). I uploaded a patch containing as only change the reformatted comment, via the Web UI ("Update Diff" at the top right corner). Should I have uploaded a "squashed" diff, containing also ALL changes that I made before (the `resize` etc)? In other words, is Phabricator expecting individual patches and it merges and accumulates them itself? Or does each new uploaded patch overwrite all previous patches?



More information about the llvm-commits mailing list