[PATCH] D152403: [Clang][CUDA] Disable diagnostics for neon attrs for GPU-side CUDA compilation

[Alexander Shaposhnikov via Phabricator via llvm-commits]

alexander-shaposhnikov added inline comments.


================
Comment at: clang/test/SemaCUDA/neon-attrs.cu:2
+// RUN: %clang_cc1 -triple arm64-linux-gnu -target-feature +neon -x cuda -fsyntax-only -DNO_DIAG -verify %s
+// RUN: %clang_cc1 -triple arm64-linux-gnu -target-feature -neon -x cuda -fsyntax-only -verify %s
+
----------------
tra wrote:
> You should also pass `-aux-triple nvptx64...`.
> 
> This also needs more test cases. This only tests host-side CUDA compilation.
> We also need:
> ```
> // GPU-side compilation on ARM (no errors expected)
> // RUN: %clang_cc1 -aux-triple arm64-linux-gnu -triple nvptx64 -fcuda-is-device  -x cuda -fsyntax-only -DNO_DIAG -verify %s
> // Regular C++ compilation on x86 and ARM without neon (should produce diagnostics) 
> // RUN: %clang_cc1  -triple x86.... -x c++ -fsyntax-only -verify %s
> // RUN: %clang_cc1  -triple arm64... -x c++ -target-feature -neon -fsyntax-only -verify %s
> // C++ on ARM w/ neon (no diagnostics)
> // RUN: %clang_cc1  -triple arm64... -x c++ -target-feature +neon -fsyntax-only -DNO_DIAG -verify %s
> ``` 
regular C++ compilation is covered by other in-tree tests, do we really need it here ?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D152403/new/

https://reviews.llvm.org/D152403