[PATCH] D151353: [DebugInfo] Add error-handling to DWARFAbbreviationDeclarationSet

Alex Langford via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Wed Jun 7 17:54:20 PDT 2023


bulbazord added a comment.

In D151353#4402741 <https://reviews.llvm.org/D151353#4402741>, @jhenderson wrote:

> Latest changes look fine, but there are a number of failures in the pre-merge check. Is this patch based on another pending commit? If so, please make sure to update the parent/child relationship that Phabricator knows about by selecting the Edit Related Revisions option in the UI and updating accordingly. You could also put in the child patch description "Depends on D......" (where D...... is the relevant patch ID).

This patch is not based on another pending commit, it looks like these these are a result of this change. Normally I run the test suite before submitting a patch but I don't have a memory of doing that again here, so I'm assuming that I didn't. I'll dig into it, thanks for the help.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D151353/new/

https://reviews.llvm.org/D151353



More information about the llvm-commits mailing list