[PATCH] D152414: AMDGPU: Do not not force alwaysinline with calls and module LDS enabled

Matt Arsenault via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Wed Jun 7 17:22:57 PDT 2023


arsenm created this revision.
arsenm added reviewers: AMDGPU, JonChesterfield, scchan, rampitec, Pierre-vh, cdevadas.
Herald added subscribers: foad, kerbowa, hiraditya, tpr, dstuttard, yaxunl, jvesely, kzhuravl.
Herald added a project: All.
arsenm requested review of this revision.
Herald added a subscriber: wdng.
Herald added a project: LLVM.

Function calls are now well supported. We used to also need this for
dealing with LDS uses in functions, but now that should also work.
This also removes the stress calls option, which would require moving
the flag to the TargetMachine and I no longer think it's useful.

      

We should probably drop the amdgpu-function-calls too but I think
hipcc is still using it.

      

This trims the pass list nicely.


https://reviews.llvm.org/D152414

Files:
  llvm/lib/Target/AMDGPU/AMDGPUAlwaysInlinePass.cpp
  llvm/lib/Target/AMDGPU/AMDGPUTargetMachine.cpp
  llvm/test/CodeGen/AMDGPU/force-alwaysinline-lds-global-address-codegen.ll
  llvm/test/CodeGen/AMDGPU/force-alwaysinline-lds-global-address.ll
  llvm/test/CodeGen/AMDGPU/llc-pipeline.ll
  llvm/test/CodeGen/AMDGPU/smed3.ll
  llvm/test/CodeGen/AMDGPU/stress-calls.ll
  llvm/test/CodeGen/AMDGPU/umed3.ll

-------------- next part --------------
A non-text attachment was scrubbed...
Name: D152414.529477.patch
Type: text/x-patch
Size: 14018 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20230608/b5f484fe/attachment-0001.bin>


More information about the llvm-commits mailing list