[PATCH] D152408: AMDGPU: Avoid endpgm in middle of block for fallback trap lowering.

Matt Arsenault via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Wed Jun 7 16:20:12 PDT 2023


arsenm created this revision.
arsenm added reviewers: AMDGPU, JonChesterfield, kzhuravl, Pierre-vh, rampitec, ruiling, critson.
Herald added subscribers: foad, kerbowa, hiraditya, tpr, dstuttard, yaxunl, jvesely.
Herald added a project: All.
arsenm requested review of this revision.
Herald added a subscriber: wdng.
Herald added a project: LLVM.

This was inserting an s_endpgm in the middle of the block when it has
to be a terminator. Split the block and insert a branch to a new block
with the trap if it's not in a terminator position.

      

Fixes verifier error on LDS in function with no trap support (and
other trap sources).


https://reviews.llvm.org/D152408

Files:
  llvm/lib/Target/AMDGPU/AMDGPUISelLowering.cpp
  llvm/lib/Target/AMDGPU/AMDGPUISelLowering.h
  llvm/lib/Target/AMDGPU/AMDGPUInstrInfo.td
  llvm/lib/Target/AMDGPU/AMDGPULegalizerInfo.cpp
  llvm/lib/Target/AMDGPU/SIISelLowering.cpp
  llvm/lib/Target/AMDGPU/SIInstructions.td
  llvm/test/CodeGen/AMDGPU/lds-global-non-entry-func.ll
  llvm/test/CodeGen/AMDGPU/trap.ll

-------------- next part --------------
A non-text attachment was scrubbed...
Name: D152408.529464.patch
Type: text/x-patch
Size: 27350 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20230607/3c88ca1d/attachment.bin>


More information about the llvm-commits mailing list