[PATCH] D152399: [CodeGen] Fine tune MachineFunctionSplitPass (MFS) for FSAFDO.

[Snehasish Kumar via Phabricator via llvm-commits]

snehasish requested changes to this revision.
snehasish added inline comments.
This revision now requires changes to proceed.


================
Comment at: llvm/test/CodeGen/X86/fsafdo_mfs_test.ll:1
+; RUN: llc -enable-fs-discriminator -improved-fs-discriminator=true -split-machine-functions < %s 2>&1 | FileCheck %s --check-prefixes=MFS
+; RUN: llc -enable-fs-discriminator -improved-fs-discriminator=true < %s 2>&1 | FileCheck %s --check-prefixes=NOMFS
----------------
I think we can write a smaller test by reusing the code in test/CodeGen/X86/machine-function-splitter.ll. The only thing we need to check there is that if `-enable-fs-discriminator` and `-improved-fs-discriminator=true` then the cold count which has value and that value is 0 is split. 

The closest test case is foo4 on L65 in machine-function-splitter.ll. I would suggest copying that and adding the necessary check.





Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D152399/new/

https://reviews.llvm.org/D152399