[PATCH] D144008: [DebugMetadata][DwarfDebug][CodeView] Support function-local static variables in lexical block scopes (6/7)

Wed Jun 7 15:16:35 PDT 2023

ykhatav added a comment.

In D144008#4403456 <https://reviews.llvm.org/D144008#4403456>, @dzhidzhoev wrote:

> In D144008#4403052 <https://reviews.llvm.org/D144008#4403052>, @ykhatav wrote:
>
>> In D144008#4401633 <https://reviews.llvm.org/D144008#4401633>, @dzhidzhoev wrote:
>>
>>> @akhuang @rnk @ykhatav could you please take a look at CodeViewReader.cpp change? Frankly, I am new to that format.
>>
>> Thanks for taking care of this. Could you add a CodeView-specific test to make sure that the changes work as expected?
>
> It seems that `llvm/test/DebugInfo/COFF/global_visibility.ll` test ensures that local/static local/global variables are handled properly. DISubprogram's `retainedNodes` references a few static local variables, and we check that these variables are present within CodeView dump. Is there a corner case I probably miss?

Thanks for pointing that out. The CodeView changes look good to me.

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D144008/new/

https://reviews.llvm.org/D144008